Switch to rustls #26
Merged
Switch to rustls #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interesting that it shows only slightly difference in binary size.
type | size (bytes)
-------------------|-------------
rustls release | 105'733'800
rustls debug | 378'907'624
native-tls release | 104'115'576
native-tls debug | 366'341'720
Interesting that during testing I've found out that rustls was
"significantly" faster on gitlab CI (at least) during connect phase,
since for native-tls I have to increase timeout few times (now connect
timeout is 5s for this build), while for rustls it works out of the box
(default connect timeout is 500ms).
|
Interesting that during testing I've found out that rustls was "significantly" faster on gitlab CI (at least) during connect phase, since for native-tls I have to increase timeout few times (now connect timeout is 5s for this build), while for rustls it works out of the box (default connect timeout is 500ms) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interesting that it shows only slightly difference in binary size.
Refs: azat-rust/clickhouse-rs#1 (will review this changes by myself firstly and then will submit to upstream)
Refs: suharev7/clickhouse-rs#209
Fixes: #18
Refs: https://jbp.io/2019/07/01/rustls-vs-openssl-performance.html