g11n-related infrastructure upgrade #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@tdd thank you! however, can this be auto merge ready? |
…BodyParser. All works.
|
Hey Azat, Woah, there had been quite some changes on master in the meantime, sorry I had missed that. I'm reworking my |
azat-co
pushed a commit
that referenced
this pull request
Feb 21, 2015
g11n-related infrastructure upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
First, thanks for ExpressWorks, it's great!
As part of the nodeschool/organizers#64 effort, I went on and localized
expressworkstofr. For this to be feasible, it had to be ported to the latest version ofworkshopper(2.3.1), which required a complete overhaul of the exercise code.I figured it would be just as good to verify that the workshop still works on the latest versions of Express, Stylus, Jade and body-parser, so I updated these deps too and went again through all exercises, successfully (the dep were not too old, so that was smooth).
I'm also submitting a subsequent PR for the fr L10n specifically, that builds on top of this one. You could merge that second PR alone and be done with the whole thing, but I believe handling this one first, and the
l10n-frone next, makes for better separation of concerns.We're trying to get this whole translation in npm by Friday night, if that's at all possible wrt your own schedule, as we're hosting the first Paris, FR NodeSchool on Saturday 😉
I've already translated and merged in
learnyounode, and many, many more are on the way.I am, obviously, available for any questions.