Added Cloud check call to main #282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoubfaouzi
requested changes
Apr 1, 2025
| @@ -0,0 +1,91 @@ | |||
| #include <winsock2.h> | |||
There was a problem hiding this comment.
This check should Live in: https://github.com/ayoubfaouzi/al-khaser/blob/master/al-khaser/AntiVM/Generic.cpp
| // create socket | ||
| SOCKET sock = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP); | ||
| if (sock == INVALID_SOCKET) { | ||
| std::cerr << "Socket creation failed.\n"; |
There was a problem hiding this comment.
Maybe goto Cleanup and do all the necessary cleanup there ?
There was a problem hiding this comment.
Could you provide more information?
There was a problem hiding this comment.
Basically in all failing condition, instead of having to do cleanup in every single failing block, just do a goto cleanup, then at the end of the function, do your proper cleanup.
Btw you need to rebase or merge main to your branch.
There was a problem hiding this comment.
I created a new pull request. I had to discard the old commits because of the conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.