clippy: allow running without cross toolchain #1243
Conversation
Upstream isn't planning to do this.
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This removes octorust which takes absolutely ages to compile and also requires native TLS libraries which in turn require a C toolchain. The latter is a pain when cross compiling from macOS. This reverts commit cc2da4a.
Remove vector preallocation in the uncompressed case; the standard library implementation of `io::Read` for `fs::File` already does this.
Make the xz2 dependency optional to allow building without a C cross compiler. This allows clippy.sh to be used on e.g. macOS more easily: ``` ./clippy.sh --target x86_64-unknown-linux-gnu --exclude-features xz2 ```
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 3 of 3 files at r3, 3 of 3 files at r4, 1 of 1 files at r5, 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dave-tucker)
test-distro/src/lib.rs line 52 at r4 (raw file):
xz2::read::XzDecoder::new(f).read_to_end(&mut contents) } else { f.read_to_end(&mut contents)
Should we reserve in this case as well? We could just use stat.len().
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dave-tucker and @vadorovsky)
test-distro/src/lib.rs line 52 at r4 (raw file):
Previously, vadorovsky (Michal Rostecki) wrote…
Should we
reservein this case as well? We could just usestat.len().
This removal is explained in the commit message.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @dave-tucker)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 3 of 3 files at r3, 3 of 3 files at r4, 1 of 1 files at r5, 3 of 3 files at r6, all commit messages.
Reviewable status:
This change is