Refactor TimeFormatter #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
===================================
Coverage 97% 97%
===================================
Files 96 96
Lines 3437 3347 -90
===================================
- Hits 3320 3243 -77
+ Misses 117 104 -13 ☔ View full report in Codecov by Sentry. |
axunonb
force-pushed
the
pr/timefmt
branch
2 times, most recently
from
f756194 to
28c4c5a
Compare
- `SmartFormat.Extensions.Time.csproj` includes `System.Text.Json`. - Enhance `TimeFormatter` to handle `TimeOnly` type (in supported frameworks). - Update `CommonLanguagesTimeTextInfo` to load data from JSON resources and marked old properties as obsolete. - Add JSON resource files for de, en, es, fr, it, pt languages. - Accept `TimeOnly` argument for NET6_0_OR_GREATER - Introduce `TimeTextInfoData` struct to read localization data from JSON - Update and add tests in `TimeFormatterTests`.
imprima
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SmartFormat.Extensions.Time.csprojincludesSystem.Text.Json.TimeFormatterto handleTimeOnlytype (in supported frameworks).CommonLanguagesTimeTextInfoto load data from JSON resources and marked old properties as obsolete.TimeTextInfoDatastruct to read localization data from JSONTimeFormatterTests.TimeFormatter