-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(script): implement revoke-role
#209
Open
github-actions
wants to merge
15
commits into
feature/script
Choose a base branch
from
implement-feature/script/revoke-role
base: feature/script
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(script): implement revoke-role
#209
github-actions
wants to merge
15
commits into
feature/script
from
implement-feature/script/revoke-role
+699
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyhuynh3103
previously approved these changes
May 17, 2024
TuDo1403
reviewed
May 17, 2024
TuDo1403
force-pushed
the
implement-feature/script/revoke-role
branch
2 times, most recently
from
June 25, 2024 07:01
13fc51e
to
3186481
Compare
TuDo1403
reviewed
Jul 11, 2024
TuDo1403
reviewed
Jul 11, 2024
ducthotran2010
previously approved these changes
Jul 12, 2024
TuDo1403
force-pushed
the
implement-feature/script/revoke-role
branch
from
July 15, 2024 04:12
cfc47ca
to
adfe7b4
Compare
feat(script): implement
|
Severity Level | Results | |
---|---|---|
Contracts | Critical High Medium Low Note Total |
2 1 0 8 26 37 |
Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
khanhtaskymaviscom
approved these changes
Jul 15, 2024
TuDo1403
force-pushed
the
implement-feature/script/revoke-role
branch
from
July 15, 2024 09:08
83c3cc4
to
2047781
Compare
TuDo1403
force-pushed
the
implement-feature/script/revoke-role
branch
from
October 2, 2024 06:34
f8bf077
to
d727fff
Compare
TuDo1403
reviewed
Oct 2, 2024
script/20240516-revoke-roles/02_GrantAdminRoleForMultisig_Mainnet.s.sol
Outdated
Show resolved
Hide resolved
huyhuynh3103
previously approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
script/20240516-revoke-roles/02_GrantAdminRoleForMultisig_Mainnet.s.sol
Outdated
Show resolved
Hide resolved
script/20240516-revoke-roles/02_GrantAdminRoleForMultisig_Mainnet.s.sol
Outdated
Show resolved
Hide resolved
khanhtaskymaviscom
approved these changes
Oct 4, 2024
ducthotran2010
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to merge from implement-feature/script/revoke-role to feature/script.