Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(distribution)!: custom fee allocation #2231

Merged
merged 5 commits into from
Jan 31, 2025
Merged

feat(distribution)!: custom fee allocation #2231

merged 5 commits into from
Jan 31, 2025

Conversation

haiyizxx
Copy link
Contributor

@haiyizxx haiyizxx commented Jan 28, 2025

Description

This pr changes fee allocation to keep the community pool portion and burn the rest.

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@haiyizxx haiyizxx marked this pull request as ready for review January 29, 2025 19:46
@haiyizxx haiyizxx requested a review from a team as a code owner January 29, 2025 19:46
@haiyizxx haiyizxx added the next release Required for the next release label Jan 29, 2025
@haiyizxx haiyizxx force-pushed the burn-fee branch 3 times, most recently from b0f58dd to a2f4a6c Compare January 29, 2025 21:02
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 23.43096% with 549 lines in your changes missing coverage. Please review.

Project coverage is 39.10%. Comparing base (ef91531) to head (a1e6f25).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/distribution/types/mock/expected_keepers.go 15.97% 540 Missing and 7 partials ⚠️
x/distribution/keeper/keeper.go 95.45% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2231      +/-   ##
==========================================
- Coverage   39.39%   39.10%   -0.29%     
==========================================
  Files         375      379       +4     
  Lines       37417    38132     +715     
==========================================
+ Hits        14739    14911     +172     
- Misses      21730    22265     +535     
- Partials      948      956       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

x/distribution/keeper/keeper.go Outdated Show resolved Hide resolved
x/distribution/keeper/keeper.go Show resolved Hide resolved
x/distribution/types/types.go Show resolved Hide resolved
@cgorenflo cgorenflo merged commit 6563117 into main Jan 31, 2025
6 of 9 checks passed
@cgorenflo cgorenflo deleted the burn-fee branch January 31, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Required for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants