fio replay: replay I/O from __BLK_TA_ISSUE action instead of __BLK_TA_QUEUE - #2133
Open
rorychen wants to merge 1 commit into
Open
fio replay: replay I/O from __BLK_TA_ISSUE action instead of __BLK_TA_QUEUE#2133rorychen wants to merge 1 commit into
rorychen wants to merge 1 commit into
Conversation
…_QUEUE Use __BLK_TA_ISSUE instead of __BLK_TA_QUEUE action events for fio replay. IO requests may be merged after __BLK_TA_QUEUE, causing replayed I/O to differ from the actual I/O issued to the driver. Replaying from __BLK_TA_ISSUE more accurately reflects device traffic. This change also fixes a bug where write requests with the BLK_TC_FLUSH category would be lost when replaying from __BLK_TA_QUEUE action. Signed-off-by: Rory Chen <rory.c.chen@seagate.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fio replay: replay I/O from __BLK_TA_ISSUE action instead of __BLK_TA_QUEUE
Use __BLK_TA_ISSUE instead of __BLK_TA_QUEUE action events for fio replay. IO requests may be merged after __BLK_TA_QUEUE, causing replayed I/O to differ from the actual I/O issued to the driver. Replaying from __BLK_TA_ISSUE more accurately reflects device traffic.
This change also fixes a bug where write requests with the BLK_TC_FLUSH category would be lost when replaying from __BLK_TA_QUEUE action.