Skip to content

trimwrite: do not terminate between a trim and its paired write #2131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vladyyy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

trimwrite: do not terminate between a trim and its paired write #2131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion backend.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,6 +1150,17 @@ void on_fsync_completed(struct thread_data *td, struct io_u *io_u)
*
* Returns number of bytes written and trimmed.
*/
static bool trimwrite_mid_pair(struct thread_data *td)

@vincentkfu vincentkfu Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above this function applies to do_io()

{
struct fio_file *f;

if (!td_trimwrite(td) || td->o.nr_files != 1)

@vincentkfu vincentkfu Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

td_trimwrite() just checks if the write and trim bits of the job's ddir are set. Both of the bits are set for rw=[rand]trimwrite but can also be set for iolog replay jobs. Would this check cause an iolog replay job that includes trims and writes to exceed its specified runtime?

return false;

f = td->files[0];
return f->last_start[DDIR_WRITE] != f->last_start[DDIR_TRIM];
}

static void do_io(struct thread_data *td, uint64_t *bytes_done)
{
unsigned int i;
Expand Down Expand Up @@ -1211,7 +1222,8 @@ static void do_io(struct thread_data *td, uint64_t *bytes_done)

if (runtime_exceeded(td, &td->ts_cache)) {
__update_ts_cache(td);
if (runtime_exceeded(td, &td->ts_cache)) {
if (runtime_exceeded(td, &td->ts_cache) &&
!trimwrite_mid_pair(td)) {
fio_mark_td_terminate(td);
break;
}
Expand All @@ -1228,6 +1240,7 @@ static void do_io(struct thread_data *td, uint64_t *bytes_done)
*/
if (bytes_issued >= total_bytes &&
!td->o.read_iolog_file &&
!trimwrite_mid_pair(td) &&

@vincentkfu vincentkfu Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bytes_issued is adjusted near the top of do_io() for trimwrite workloads. Why is this check necessary here?

(!td->o.time_based ||
(td->o.time_based && td->o.verify != VERIFY_NONE)))
break;
Expand Down
Loading