Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assume role authorization tests #880

Merged
merged 6 commits into from
May 22, 2024
Merged

Conversation

monthonk
Copy link
Contributor

Description of change

Currently, we don't have any tests that verify mountpoint can assume a role configured in the CLI config file. This change adds some tests to cover them.

Relevant issues: #861

Does this change impact existing behavior?

No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@monthonk monthonk had a problem deploying to PR integration tests May 16, 2024 19:20 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 16, 2024 19:20 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 16, 2024 19:20 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 16, 2024 19:20 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 16, 2024 19:20 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 16, 2024 19:20 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 16, 2024 19:20 — with GitHub Actions Failure
@monthonk monthonk requested a deployment to PR integration tests May 17, 2024 10:31 — with GitHub Actions Waiting
@monthonk monthonk requested a deployment to PR integration tests May 17, 2024 10:31 — with GitHub Actions Waiting
@monthonk monthonk requested a deployment to PR integration tests May 17, 2024 10:31 — with GitHub Actions Waiting
@monthonk monthonk requested a deployment to PR integration tests May 17, 2024 10:31 — with GitHub Actions Waiting
@monthonk monthonk requested a deployment to PR integration tests May 17, 2024 10:31 — with GitHub Actions Waiting
@monthonk monthonk requested a deployment to PR integration tests May 17, 2024 10:31 — with GitHub Actions Waiting
@monthonk monthonk requested a deployment to PR integration tests May 17, 2024 10:31 — with GitHub Actions Waiting
@monthonk monthonk had a problem deploying to PR integration tests May 17, 2024 10:33 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 17, 2024 10:33 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 17, 2024 10:33 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 17, 2024 10:33 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 17, 2024 10:33 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 17, 2024 10:33 — with GitHub Actions Failure
@monthonk monthonk had a problem deploying to PR integration tests May 17, 2024 10:33 — with GitHub Actions Failure
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments

mountpoint-s3-client/tests/auth.rs Outdated Show resolved Hide resolved
mountpoint-s3/tests/common/s3.rs Outdated Show resolved Hide resolved
mountpoint-s3/tests/fuse_tests/fork_test.rs Outdated Show resolved Hide resolved
Signed-off-by: Monthon Klongklaew <[email protected]>
Signed-off-by: Monthon Klongklaew <[email protected]>
@monthonk monthonk temporarily deployed to PR integration tests May 21, 2024 16:46 — with GitHub Actions Inactive
@monthonk monthonk temporarily deployed to PR integration tests May 21, 2024 16:46 — with GitHub Actions Inactive
@monthonk monthonk temporarily deployed to PR integration tests May 21, 2024 16:46 — with GitHub Actions Inactive
@monthonk monthonk temporarily deployed to PR integration tests May 21, 2024 16:46 — with GitHub Actions Inactive
@monthonk monthonk temporarily deployed to PR integration tests May 21, 2024 16:46 — with GitHub Actions Inactive
@monthonk monthonk temporarily deployed to PR integration tests May 21, 2024 16:46 — with GitHub Actions Inactive
@monthonk monthonk temporarily deployed to PR integration tests May 21, 2024 16:46 — with GitHub Actions Inactive
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@monthonk monthonk enabled auto-merge May 21, 2024 17:12
@monthonk monthonk added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 21, 2024
@dannycjones dannycjones added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@jamesbornholt jamesbornholt added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 21, 2024
@jamesbornholt jamesbornholt added this pull request to the merge queue May 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 22, 2024
@dannycjones dannycjones added this pull request to the merge queue May 22, 2024
Merged via the queue into awslabs:main with commit e608ce2 May 22, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants