-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor error handling on read requests #750
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I had one question. Why are we directly returning Bytes
from prefetcher rather than converting them from ChecksummedBytes
at the fs
level?
|
I kind of think we might prefer to keep the prefetcher returning |
@jamesbornholt, @sauraank, I reverted the change to the return type of |
Ok, but now I'm not sure why we need this change — does moving the error parsing logic out into a |
Fair question. You're right, this is not really tied to #644 anymore, but I do see moving the |
Signed-off-by: Alessandro Passaro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description of change
Minor refactor to simplify how errors returned from
Prefetch::read()
are handled. It implements the error conversion in thefs::error
module, to align it to errors on the write path.Preliminary work for #644
Does this change impact existing behavior?
No change in behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).