Split tasks into separate MNG and SMNG tasks #507
Conversation
…meters to be more consistent across the repo
…nd self-managed node groups
shvbsle
changed the title
| default: "https://raw.githubusercontent.com/awslabs/kubernetes-iteration-toolkit/main/tests/assets/asg_node_group.yaml" | ||
| - name: launch-template-ami | ||
| default: "" | ||
| description: "Launch template ImageId value, which may be an AMI ID or resolve:ssm reference. By default resolve to the lates AL2023 ami for cluster version" | ||
| type: string | ||
| - name: ng-cfn-url-monitoring | ||
| default: "https://raw.githubusercontent.com/awslabs/kubernetes-iteration-toolkit/main/tests/assets/eks_node_group_launch_template.json" | ||
| - default: "https://raw.githubusercontent.com/awslabs/kubernetes-iteration-toolkit/main/tests/assets/eks_node_group_launch_template_al2023.yaml" |
There was a problem hiding this comment.
Now that we have split these into two separate tasks, leave defaults at task level.
That way, we can keep changes to pipeline def as minimal as possible.
There was a problem hiding this comment.
Made these changes in the latest commit.
Do note that this becomes slightly inconsistent with how other params such as ng-cfn-url are defined in the pipeline, which do have default values. The only caution here would be that by moving these defaults to task-level definition, we are losing top-level visibility on what is being used under the hood by these task.
There was a problem hiding this comment.
Yeah, we need to move those as well to task level defaults, to keep pipeline minimal. Main motivation is - basically to not have to change all downstream pipelines built using these tasks as and when we change the defaults.
tests/tekton-resources/pipelines/eks/awscli-cl2-load-with-addons-slos.yaml
Outdated
Show resolved
Hide resolved
|
Thanks for following up on this task. |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.