-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance Spark operator blueprint to add S3 Tables support #721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few minor comments. It's good to go once these are addressed.
Let's create a separate PR for WebSite doc for this feature with screenshots. Thanks
analytics/terraform/spark-k8s-operator/examples/s3-tables/README.md
Outdated
Show resolved
Hide resolved
analytics/terraform/spark-k8s-operator/examples/s3-tables/s3table-iceberg-pyspark.py
Outdated
Show resolved
Hide resolved
analytics/terraform/spark-k8s-operator/examples/s3-tables/s3table-spark-operator.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Manabu McCloskey <[email protected]>
type: Python | ||
sparkVersion: "3.5.3" | ||
mode: cluster | ||
image: "public.ecr.aws/data-on-eks/spark:3.5.3-scala2.12-java17-python3-ubuntu-s3table0.1.3-iceberg1.6.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a comment here saying..
# CAUTION: Unsupported test image
# This image is created solely for testing and reference purposes.
# Before use, please:
# 1. Review the Dockerfile used to create this image
# 2. Create your own image that meets your organization's security requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this caution to all our test images as a part of next PR
Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does this PR do?
Adds support for S3 Tables in Spark operator blueprint.
🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
Motivation
Fixes #713
More
website/docs
orwebsite/blog
section for this featurepre-commit run -a
with this PR. Link for installing pre-commit locallyFor Moderators
Additional Notes