Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spark benchmarking updates with generic files #688

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

vara-bonthu
Copy link
Collaborator

@vara-bonthu vara-bonthu commented Oct 30, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction. When we triage the issues, we will add labels to the issue like "Enhancement", "Bug" which should indicate to you that this issue can be worked on and we are looking forward to your PR. We would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Generic Managed node groups for Spark benchmarking
  • One node group for EBS and another one for SSD. x86 and ARM can be modified accrodingly
  • Apache YuniKorn is disabled due to some issues with either latest YuniKorn or the integration with Spark operator. Will investigate further
  • Updated Spark Operator Manifests - one for EBS and another one for SSD to use shuffle as storage

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu marked this pull request as ready for review October 30, 2024 15:50
Copy link
Contributor

@alanty alanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vara-bonthu vara-bonthu merged commit 13ecbc4 into main Oct 30, 2024
37 of 39 checks passed
@vara-bonthu vara-bonthu deleted the spark-fixes branch October 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants