Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use unique name for the spark job execution IRSA policy #672

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

alanty
Copy link
Contributor

@alanty alanty commented Oct 10, 2024

What does this PR do?

Create a unique name for the spark job execution IRSA policy by using name_prefix instead of name.
solves #668

Motivation

If you deploy the solution with the same name and account but different regions, the name of this policy conflicts and blocks the creation.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

this could just as easily be avoided by not using the same name in the variables for the solution.

@alanty alanty changed the title Use unique name for the spark job execution IRSA policy feat: Use unique name for the spark job execution IRSA policy Oct 10, 2024
@vara-bonthu vara-bonthu merged commit 537da53 into awslabs:main Oct 11, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants