Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed NIM pattern install.sh script and NGC Key instruction #582

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

hustshawn
Copy link
Contributor

@hustshawn hustshawn commented Jul 13, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Updated the logic in install.sh script. When customer using NIM pattern, should not check the HuggingFace token for Triton pattern
  • Updated the NVIDIA NGC API Key instructions. More detailed instruction added, and emphasized the requirement for NVIDIA AI Enterprie registration. It is mandatory for using NIM, but it's not even clearly addressed in the current NIM doc.
  • Also updated the website doc to make it make it clear for customer to follow.

Motivation

Fixed NIM pattern install.sh script and NGC Key instruction

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu merged commit 5b9b8dc into awslabs:main Jul 14, 2024
37 of 38 checks passed
ovaleanu pushed a commit to ovaleanu/data-on-eks that referenced this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants