Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to latest Karpenter and s3 mount example #427

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

vara-bonthu
Copy link
Collaborator

@vara-bonthu vara-bonthu commented Feb 8, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Update to latest Karpenter
  • removed the userdata for RAID0
  • added example for S3 mountpoint. Example will be extended in the later PR

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Copy link
Contributor

@lusoal lusoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vara-bonthu I left few comments, but LGTM

@@ -42,7 +42,7 @@ spec:
"spark.app.name": "taxi-trip"
"spark.kubernetes.driver.pod.name": "taxi-trip"
"spark.kubernetes.executor.podNamePrefix": "taxi-trip"
"spark.local.dir": "/data1"
# "spark.local.dir": "/data1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the local.dir is spark.local.dir": "/data I think we can remove it from here

@vara-bonthu vara-bonthu merged commit 1fd8438 into main Feb 10, 2024
50 of 52 checks passed
@vara-bonthu vara-bonthu deleted the mountpoint-s3 branch February 10, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants