Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update ray-cluster karpenter_provisioner capacity-type to on-demand #424

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bluecrayon52
Copy link
Contributor

Update ray-cluster karpenter_provisioner capacity-type to on-demand

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

The Karpenter Provisioner created for the Ray on EKS xgboost example is set to use a "spot" capacity-type, which failed to provision the required additional node. As a result, the the xgboost head node pods got stuck in a pending state. After changing the capacity-type to on-demand, a new M5a.4xlarge instance was successfully deployed and added to the ray-cluster as a node, allowing the xgboost head node pods to run.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Update ray-cluster karpenter_provisioner spec.requirements.values to "on-demand"
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 4, 2024
@askulkarni2 askulkarni2 removed the stale label Mar 4, 2024
Copy link
Collaborator

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! In the near future we will be deprecating this blueprint in the favor of an updated JARAK stack.

@askulkarni2 askulkarni2 changed the title Update ray-cluster karpenter_provisioner capacity-type to on-demand fix: Update ray-cluster karpenter_provisioner capacity-type to on-demand Mar 11, 2024
@askulkarni2 askulkarni2 merged commit 59ee683 into awslabs:main Mar 11, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants