Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed Karpenter manifests to match newer version os Karpenter v0.32.1 #384

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

lusoal
Copy link
Contributor

@lusoal lusoal commented Dec 7, 2023

What does this PR do?

This PR updates Karpenter manifests to use the new objects NodePool and NodeClass

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Since Karpenter was donated to Kubernetes sig they have standardize Karpenter CRDs to use NodePool and NodeClass, this PR updates the Helm chart used to manage Karpenter resources.

Motivation

Fix for issue #381

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 merged commit e54b0c0 into awslabs:main Dec 7, 2023
46 of 47 checks passed
@vara-bonthu
Copy link
Collaborator

@lusoal Nice work on this 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants