Prepare for v0.7.0 release #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianxjcraig
force-pushed
the
v0.7.0-release
branch
4 times, most recently
from
061b954 to
9af17aa
Compare
sam-berning
approved these changes
Apr 2, 2025
Cargo.toml
Outdated
Comment on lines
21
to
22
| aws-sdk-ebs = { version = "1", default-features = false, features = ["rt-tokio", "default-https-client"] } | ||
| aws-sdk-ec2 = { version = "1", default-features = false, features = ["rt-tokio", "default-https-client"] } |
There was a problem hiding this comment.
nit: features not in alphabetical order:
Suggested change
| aws-sdk-ebs = { version = "1", default-features = false, features = ["rt-tokio", "default-https-client"] } | |
| aws-sdk-ec2 = { version = "1", default-features = false, features = ["rt-tokio", "default-https-client"] } | |
| aws-sdk-ebs = { version = "1", default-features = false, features = ["default-https-client", "rt-tokio"] } | |
| aws-sdk-ec2 = { version = "1", default-features = false, features = ["default-https-client", "rt-tokio"] } |
qianxjcraig
force-pushed
the
v0.7.0-release
branch
2 times, most recently
from
5c6b9cd to
db611b1
Compare
sam-berning
approved these changes
Apr 2, 2025
cbgbt
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Nice!
From what I can tell, ring is present in Cargo.lock, but it's not actually used and is only shown due to this bug: rust-lang/cargo#10801
I verified this by running cargo tree, which doesn't surface ring at all.
|
After peeking a bit, I think we can upgrade Likewise, I think |
qianxjcraig
force-pushed
the
v0.7.0-release
branch
from
db611b1 to
3267e63
Compare
…dependencies - Update cargo-deny installation to use latest version - Remove legacy `rustls` feature that enabled the old TLS stack (hyper 0.14 + rustls 0.21 + ring) - Enable only `default-https-client` and `rt-tokio` to use the new default SDK configuration
qianxjcraig
force-pushed
the
v0.7.0-release
branch
from
3267e63 to
bd79856
Compare
cbgbt
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.