Gracefully handle rejected token Promise while creating real time subscription handshake link #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MUlfers
changed the title
MUlfers
force-pushed
the
bugfix/handle-rejected-token-prmose-when-starting-subscription
branch
from
7d15cbd
to
37bfc21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When using authentication type AWS_LAMBDA and providing the token as
() => Promise<string>there is the possibility that the Promise is rejected.The Promise is awaited with the call
await this._awsRealTimeHeaderBasedAuthoutside of any try catch block. This lead to a "Unhandled rejected promise" exception.By moving the call into the existing try-catch block a rejected token Promise will be handled gracefully.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.