Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check observer exists handleIncomingSubscriptionMessage #645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pckilgore
Copy link

@pckilgore pckilgore commented Jun 15, 2021

No Issue, although similar in nature to #515 #544 #596 (and PRs #609, #595).

Check observer exists before calling its methods in AppSyncRealTimeSubscriptionHandshakeLink##_handleIncomingSubscriptionMessage

This observer is being defaulted to null here, so I assume checking that and ignoring the event after logging is fine since I would expect the method to bail there rather than initialize to an invalid value?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
I Agree.

@pckilgore
Copy link
Author

Bumping. What can I do here to help get it merged?

@pckilgore
Copy link
Author

Hello again. Can I do anything to assist this is being merged?

@Dollab
Copy link

Dollab commented Mar 24, 2022

It would be really really great if this could be merged 🙏

@simon-q
Copy link
Contributor

simon-q commented Oct 27, 2022

I opened a PR that fixes this following the existing code.
Please review it:
#735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants