add s3 ACL in parameter to allow different file permissions #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If auto-reconnect when coming back online is needed, users should use `client.sync` (deltaSync) instead.
add promised version as valid types for CredentialsGetter - see awslabs#264
Parity with @aws-amplify/api on graphql package dependency
…ning (awslabs#347) Fixes awslabs#354 This fixes an InvalidSignatureExceptions that occurs when using iamBasedAuthentication and the '@@controlEvents' variable in subscriptions
I can't find anywhere in the console that I can download a file named AppSync.js... but I have aws-exports.js. The docs are still very confusing when new to all of these libraries that can be mixed and matched. I can get the Amplify CLI to work out of the box, but as soon as you try to add AWSAppSyncClient instead and use the Apollo client things get very confusing to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 Upload facility through AppSync is missing the key ACL parameter to pass permissions. Hence any uploads which are intended to be
public-reador take any other permission do not work, and the default private file mode is applied.The changes take the ACL parameter defaulting to private and include this in the S3 request giving more control to the end user.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.