Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add sagemaker-mlflow package #448

Merged
merged 2 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
#Add any additional packages here
conda-forge::mlflow[version='>=2.13.0,<3.0']
conda-forge::mlflow[version='>=2.13.2,<3.0']
conda-forge::sagemaker-mlflow[version='>=0.1.0,<1.0']
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
#Add any additional packages here
conda-forge::mlflow[version='>=2.13.2,<3.0']
conda-forge::sagemaker-mlflow[version='>=0.1.0,<1.0']
19 changes: 19 additions & 0 deletions test/test_artifacts/v2/sagemaker-mlflow.test.Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
ARG SAGEMAKER_DISTRIBUTION_IMAGE
FROM $SAGEMAKER_DISTRIBUTION_IMAGE

ARG MAMBA_DOCKERFILE_ACTIVATE=1

RUN python -c "import sagemaker_mlflow"

RUN sudo apt-get update && sudo apt-get install -y git && \
git clone --recursive https://github.com/aws/sagemaker-mlflow.git && \
:

# For running sagemaker-mlflow tests, we need pytest
RUN micromamba install -y --freeze-installed -c conda-forge pytest

WORKDIR "sagemaker-mlflow/"
COPY --chown=$MAMBA_USER:$MAMBA_USER scripts/run_sagemaker_mlflow_tests.sh .
RUN chmod +x run_sagemaker_mlflow_tests.sh
# Run tests in run_matplotlib_tests.sh
CMD ["./run_sagemaker_mlflow_tests.sh"]
2 changes: 2 additions & 0 deletions test/test_artifacts/v2/scripts/run_mlflow_tests.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/bin/bash

set -e

# Run examples for keras, pytorch, sklearn, tensorflow
cd examples

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#!/bin/bash

set -e

pytest -s -rA -vv test/unit
1 change: 1 addition & 0 deletions test/test_dockerfile_based_harness.py
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def test_dockerfiles_for_cpu(
("serve.test.Dockerfile", ["serve-langchain"]),
("langchain-aws.test.Dockerfile", ["langchain-aws"]),
("mlflow.test.Dockerfile", ["mlflow"]),
("sagemaker-mlflow.test.Dockerfile", ["sagemaker-mlflow"]),
],
)
def test_dockerfiles_for_gpu(
Expand Down