Skip to content

Commit

Permalink
fix: Minor readme fixes (#426)
Browse files Browse the repository at this point in the history
  • Loading branch information
claytonparnell authored May 31, 2024
1 parent 580384d commit 1d40c55
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ Follow these steps for sending out a pull request for adding new packages:
# If NEXT_VERSION is a new minor version:
python src/main.py create-minor-version-artifacts --base-patch-version=$BASE_PATCH_VERSION --force
python ./src/main.py create-minor-version-artifacts --base-patch-version=$BASE_PATCH_VERSION --force
# Or for a new major version:
python src/main.py create-major-version-artifacts --base-patch-version=$BASE_PATCH_VERSION --force
# Build the image:
python src/main.py build \
python ./src/main.py build \
--target-patch-version=$NEXT_VERSION --skip-tests
```
Expand Down
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ against an Amazon SageMaker Distribution image: this could be a pre-built image
an image that you built locally using the `build` command:

```shell
python main.py build --target-patch-version x.y.z
python ./src/main.py build --target-patch-version x.y.z
```

Run the following to invoke those tests:
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ The easiest way to get it running on your laptop is through the Docker CLI:
export ECR_IMAGE_ID='INSERT_IMAGE_YOU_WANT_TO_USE'
docker run -it \
-p 8888:8888 \
--user `id -u`:`id -g` \
-v `pwd`/sample-notebooks:/home/sagemaker-user/sample-notebooks \
$ECR_IMAGE_ID jupyter-lab --no-browser --ip=0.0.0.0
```
Expand All @@ -94,7 +93,6 @@ export ECR_IMAGE_ID='INSERT_IMAGE_YOU_WANT_TO_USE'
docker run -it \
-p 8888:8888 \
--entrypoint entrypoint-jupyter-server \
--user `id -u`:`id -g` \
-v `pwd`/sample-notebooks:/home/sagemaker-user/sample-notebooks \
$ECR_IMAGE_ID
```
Expand Down

0 comments on commit 1d40c55

Please sign in to comment.