This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
Statistics collection and thread safety fixes for AZ::IO::DedicatedCache #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More fixes for problems addressed by aws#494
|
Thanks for submitting these additional fixes @dkondrashkin, we're looking over the change and will update this PR with status changes or questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes for problems addressed by #494
While previous pull request fixed most of the issues the one remained:
DedicatedCache::DestroyDedicatedCache()call can happen right betweenDedicatedCache::CollectStatistics()call and any code that makes use of statistics collected (e.g.System.cpp @ 1745orDevice.cpp @ 96). This leads to accessing invalid memory through string views stored in statistics values and, particularly, to crashes on consoles.The solution proposed (apart form guarding internal data members with locks) is to postpone removal of
m_cachedStatNamesentries until the very beginning of the nextDedicatedCache::CollectStatistics()call.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.