Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Helm chart option to set POD container name #7384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

udhos
Copy link

@udhos udhos commented Nov 14, 2024

Fixes #7383

Description

Helm chart option to set POD container name.

Several of our observability tools rely on POD container name and "controller" is too much generic.

This change adds this option to values.yaml:

controller:
  # -- Distinguishing container name (containerName: karpenter-controller).
  containerName: controller

How was this change tested?

Using "helm template" to check it defaults to current setting (controller) and allows defining a new container name.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@udhos udhos requested a review from a team as a code owner November 14, 2024 20:33
@udhos udhos requested a review from ellistarn November 14, 2024 20:33
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 982e0d9
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67365eb0bd88aa0008cf6af2
😎 Deploy Preview https://deploy-preview-7384--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart values option to set POD container name
1 participant