Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typos on the apisv1 #7277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix typos on the apisv1 #7277

wants to merge 1 commit into from

Conversation

Vacant2333
Copy link

Fixes #N/A

Description

  • fix a typo

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Vacant2333 Vacant2333 requested a review from a team as a code owner October 25, 2024 08:28
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit e654afa
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6730a4af8b73270008adcee1

pkg/apis/v1/ec2nodeclass.go Outdated Show resolved Hide resolved
pkg/apis/v1/ec2nodeclass_status.go Outdated Show resolved Hide resolved
pkg/apis/v1/ec2nodeclass_status.go Outdated Show resolved Hide resolved
@Vacant2333
Copy link
Author

@jonathan-innis hi! thanks for your review! i have correct them now, thank u again!

pkg/apis/v1/ec2nodeclass.go Outdated Show resolved Hide resolved
pkg/apis/v1/ec2nodeclass.go Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis previously approved these changes Nov 5, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) November 5, 2024 00:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11609442806

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.873%

Totals Coverage Status
Change from base Build 11567721194: 0.0%
Covered Lines: 5642
Relevant Lines: 6808

💛 - Coveralls

Signed-off-by: Vacant2333 <[email protected]>
auto-merge was automatically disabled November 10, 2024 12:18

Head branch was pushed to by a user without write access

@Vacant2333
Copy link
Author

hi, the ci failed, i had fix it @jonathan-innis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants