Fix error formatting when HTML response #905
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreachild
reviewed
Apr 25, 2025
|
LGTM just had a small comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
+ Coverage 20.96% 30.85% +9.89%
==========================================
Files 523 534 +11
Lines 22442 23823 +1381
Branches 1198 1423 +225
==========================================
+ Hits 4704 7350 +2646
+ Misses 17494 16346 -1148
+ Partials 244 127 -117
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andreachild
reviewed
Apr 25, 2025
| (!contentType.includes("application/json") && | ||
| !contentType.includes("text/plain")) | ||
| ) { | ||
| return undefined; |
There was a problem hiding this comment.
Nit: is the error logged anywhere else? If not could use a log here that it was an unexpected type.
There was a problem hiding this comment.
Fair question, which is leading me to change some stuff. So I'm going to hold this PR for after the release.
kmcginnes
force-pushed
the
fix-error-formatting
branch
from
d4a0b06 to
033dbe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an error response contains HTML content it should be ignored, since there is no consistent way to get useful content out of the HTML.
Validation
Related Issues
Check List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.