Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc errors in concepts and getting started #6933

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Oct 30, 2023

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2023
@sp1999 sp1999 requested a review from ahreehong October 30, 2023 18:42
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d37124) 71.94% compared to head (0de91ee) 71.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6933      +/-   ##
==========================================
- Coverage   71.94%   71.93%   -0.01%     
==========================================
  Files         532      532              
  Lines       41583    41583              
==========================================
- Hits        29917    29914       -3     
- Misses       9989     9991       +2     
- Partials     1677     1678       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahreehong
Copy link
Member

/lgtm

@sp1999
Copy link
Member Author

sp1999 commented Oct 30, 2023

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 871c204 into aws:main Oct 30, 2023
@sp1999 sp1999 deleted the fix-doc-errors branch October 30, 2023 19:04
@ahreehong
Copy link
Member

/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@ahreehong: new pull request created: #7198

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants