Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/overlapping tips #5036

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix/overlapping tips #5036

merged 1 commit into from
May 28, 2024

Conversation

ivikash
Copy link
Member

@ivikash ivikash commented May 22, 2024

Problem

  1. Tips are displayed on programming languages not supported by Amazon Q
  2. First time users experience multiple onboarding tips

Solution

Before After Notes
Tip - 1 Tip - 2 Disable Tips for file types not supported by Amazon Q
Screenshot 2024-05-21 at 3 35 06 PM Screenshot 2024-05-21 at 2 06 02 PM Disable Codelens if Amazon Q Chat is open
Screenshot 2024-05-21 at 2 05 31 PM Screenshot 2024-05-21 at 5 33 52 PM Disable Codelens if tip is being displayed

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ivikash ivikash requested review from a team as code owners May 22, 2024 00:35
@ankityyz
Copy link

Tested, lgtm!

…Chat

- disable tips for filetypes not supported by amazon q
- disable codelens if amazon q chat is visible
- disable codelens if lineAnnotationController is visible
@justinmk3 justinmk3 merged commit 9edc9bd into aws:master May 28, 2024
14 checks passed
@ivikash ivikash deleted the fix/overlapping-tips branch May 28, 2024 17:40
jpinkney-aws pushed a commit that referenced this pull request May 28, 2024
Problem:
- Tips are displayed on programming languages not supported by Amazon Q
- First time users experience multiple onboarding tips

Solution:
- disable tips for filetypes not supported by amazon q
- disable codelens if amazon q chat is visible
- disable codelens if lineAnnotationController is visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants