Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amazonq): add commands to command palette #4965

Merged
merged 1 commit into from
Jun 5, 2024
Merged

feat(amazonq): add commands to command palette #4965

merged 1 commit into from
Jun 5, 2024

Conversation

ivikash
Copy link
Member

@ivikash ivikash commented May 8, 2024 •
edited by justinmk3

Problem

Add commands in Command Palette for Amazon Q to improve feature discoverability

Solution

Commands Added

  • Amazon Q: Open Chat Panel
  • Amazon Q: Open Code Reference Log
  • Amazon Q: Select Customizations
  • Amazon Q: Toggle Auto-Scans
  • Amazon Q: Toggle Auto-Suggestions
  • Amazon Q: Try inline suggestion example
  • Amazon Q: Sign Out

TODO:

  • Discuss FromCommandPalette pattern. -- Discussed offline, this is the right approach. Going forward use the same prefix and add .commandPalette as suffix.
  • Discuss telemetry/metrics

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ivikash ivikash requested a review from a team as a code owner May 8, 2024 23:47
@ivikash ivikash requested a review from leigaol May 8, 2024 23:47
justinmk3
justinmk3 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"toggle auto-suggestions" would be another good one to have in the palette

@ivikash ivikash requested review from a team as code owners May 10, 2024 05:15
@ivikash
Copy link
Member Author

ivikash commented May 27, 2024

Demo

Screen.Recording.2024-05-26.at.7.44.00.PM.mov

Metrics

Command Telemetry
Amazon Q: Open Code Reference Log 
2024-05-26 19:15:09.358 [debug] command: running "aws.amazonq.openReferencePanel.commandPalette" with arguments: []
2024-05-26 19:15:09.359 [debug] command: running "aws.amazonq.openReferencePanel" with arguments: [ 'placeholder**', 'commandPalette' ]
2024-05-26 19:15:09.381 [debug] telemetry: vscode_executeCommand {
  Metadata: {
    parentMetric: 'vscode_executeCommand',
    command: 'aws.amazonq.openReferencePanel',
    source: 'commandPalette',
    duration: '22',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:15:09.381 [debug] telemetry: vscode_executeCommand {
  Metadata: {
    command: 'aws.amazonq.openReferencePanel.commandPalette',
    duration: '24',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
Amazon Q: Try inline suggestion example 
2024-05-26 19:15:53.849 [debug] command: running "CodeWhispererCommandBackend.showGettingStartedPage" (id: aws.amazonq.gettingStarted) with arguments: []
2024-05-26 19:15:53.849 [debug] telemetry: ui_click {
  Metadata: {
    parentMetric: 'vscode_executeCommand',
    elementId: 'codewhisperer_Learn_PageOpen',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:15:53.849 [debug] telemetry: vscode_executeCommand {
  Metadata: {
    command: 'aws.amazonq.gettingStarted',
    duration: '3',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:15:53.967 [debug] Webview called command "getOSType" with args: []
Amazon Q: Open Chat Panel 
2024-05-26 19:16:17.774 [debug] command: running "aws.amazonq.openChatPanel.commandPalette" with arguments: []
2024-05-26 19:16:17.774 [debug] command: running "aws.amazonq.focusChat" with arguments: [ 'placeholder**', 'commandPalette' ]
2024-05-26 19:16:17.795 [debug] telemetry: vscode_executeCommand {
  Metadata: {
    parentMetric: 'vscode_executeCommand',
    command: 'aws.amazonq.focusChat',
    source: 'commandPalette',
    duration: '22',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:16:17.796 [debug] telemetry: vscode_executeCommand {
  Metadata: {
    command: 'aws.amazonq.openChatPanel.commandPalette',
    duration: '23',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:16:17.799 [debug] SSO token cache: loaded key: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:16:17.799 [info] current client registration id=BKZm_Lf95sS6wrGZnexbbHVzLWVhc3QtMQ, 
    expires at Tue Aug 20 2024 15:10:29 GMT-0700 (Pacific Daylight Time), 
    key = 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:16:17.799 [info] auth: Connection is valid: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:16:17.799 [info] auth: Updating connection state of 06f56967-f6e1-47f0-9ff2-5e95a9b93d10 to valid
2024-05-26 19:16:18.586 [debug] telemetry: amazonq_exitFocusChat {
  Metadata: {
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
Amazon Q: Select Customizations 
2024-05-26 19:17:09.423 [debug] telemetry: collapsing 1 "aws.amazonq.selectCustomization.commandPalette" metrics. key={}
2024-05-26 19:17:09.424 [debug] command: running "aws.amazonq.selectCustomization.commandPalette" with arguments: []
2024-05-26 19:17:09.424 [debug] telemetry: collapsing 1 "aws.amazonq.selectCustomization" metrics. key={ '1': 'source' }
2024-05-26 19:17:09.424 [debug] command: running "aws.amazonq.selectCustomization" with arguments: [ 'placeholder**', 'commandPalette' ]
2024-05-26 19:17:09.424 [debug] telemetry: ui_click {
  Metadata: {
    elementId: 'cw_selectCustomization_Cta',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: false
}
2024-05-26 19:17:09.449 [debug] SSO token cache: loaded key: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:17:09.449 [info] current client registration id=BKZm_Lf95sS6wrGZnexbbHVzLWVhc3QtMQ, 
    expires at Tue Aug 20 2024 15:10:29 GMT-0700 (Pacific Daylight Time), 
    key = 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:17:11.061 [debug] amazonq: listAvailableCustomizations API request:
    RequestID: a513a335-6ea1-4f9f-8e2c-17a0d44e324a,
    Customizations:
        00: Amazon-Internal-V1
        01: NGDE-Custom-Finetuning-7K-V2
        02: NGDE-Custom-V13
Amazon Q: Toggle Auto-Scans 
2024-05-26 19:17:51.082 [debug] telemetry: collapsing 2 "aws.codeWhisperer.toggleCodeScan.commandPalette" metrics. key={}
2024-05-26 19:17:51.083 [debug] command: running "aws.codeWhisperer.toggleCodeScan.commandPalette" with arguments: []
2024-05-26 19:17:51.083 [debug] telemetry: collapsing 2 "aws.codeWhisperer.toggleCodeScan" metrics. key={ '1': 'source' }
2024-05-26 19:17:51.083 [debug] command: running "aws.codeWhisperer.toggleCodeScan" with arguments: [ 'placeholder**', 'commandPalette' ]
2024-05-26 19:17:51.095 [debug] telemetry: aws_modifySetting {
  Metadata: {
    settingId: 'codewhisperer_autoScansActivation',
    settingState: 'Activated',
    duration: '14',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: false
}
2024-05-26 19:17:53.523 [debug] telemetry: collapsing 1 "aws.amazonq.listCommands" metrics. key={}
2024-05-26 19:17:53.523 [debug] command: running "aws.amazonq.listCommands" with arguments: []
2024-05-26 19:17:53.523 [debug] telemetry: ui_click {
  Metadata: {
    elementId: 'cw_statusBarMenu',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: false
}
2024-05-26 19:17:53.524 [debug] telemetry: collapsing 1 "aws.amazonq.refreshAnnotation" metrics. key={}
2024-05-26 19:17:53.524 [debug] command: running "aws.amazonq.refreshAnnotation" with arguments: [ true ]
2024-05-26 19:17:57.545 [debug] telemetry: collapsing 3 "aws.codeWhisperer.toggleCodeScan.commandPalette" metrics. key={}
2024-05-26 19:17:57.546 [debug] command: running "aws.codeWhisperer.toggleCodeScan.commandPalette" with arguments: []
2024-05-26 19:17:57.546 [debug] telemetry: collapsing 3 "aws.codeWhisperer.toggleCodeScan" metrics. key={ '1': 'source' }
2024-05-26 19:17:57.547 [debug] command: running "aws.codeWhisperer.toggleCodeScan" with arguments: [ 'placeholder**', 'commandPalette' ]
2024-05-26 19:17:57.557 [debug] telemetry: aws_modifySetting {
  Metadata: {
    settingId: 'codewhisperer_autoScansActivation',
    settingState: 'Deactivated',
    duration: '12',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: false
}
2024-05-26 19:17:58.616 [debug] telemetry: collapsing 2 "aws.amazonq.listCommands" metrics. key={}
2024-05-26 19:17:58.616 [debug] command: running "aws.amazonq.listCommands" with arguments: []
2024-05-26 19:17:58.617 [debug] telemetry: ui_click {
  Metadata: {
    elementId: 'cw_statusBarMenu',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: false
}
2024-05-26 19:17:58.617 [debug] telemetry: collapsing 2 "aws.amazonq.refreshAnnotation" metrics. key={}
2024-05-26 19:17:58.617 [debug] command: running "aws.amazonq.refreshAnnotation" with arguments: [ true ]
2024-05-26 19:17:59.887 [debug] telemetry: amazonq_enterFocusChat {
  Metadata: {
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:18:00.425 [debug] telemetry: amazonq_exitFocusChat {
  Metadata: {
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
Amazon Q: Toggle Auto-Suggestions 
2024-05-26 19:18:25.388 [debug] command: running "aws.amazonq.toggleCodeSuggestion.commandPalette" with arguments: []
2024-05-26 19:18:25.388 [debug] command: running "aws.amazonq.toggleCodeSuggestion" with arguments: [ 'placeholder**', 'commandPalette' ]
2024-05-26 19:18:25.391 [debug] telemetry: aws_modifySetting {
  Metadata: {
    parentMetric: 'vscode_executeCommand',
    settingId: 'codewhisperer_autoSuggestionActivation',
    settingState: 'Deactivated',
    duration: '3',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: false
}
2024-05-26 19:18:25.391 [debug] telemetry: vscode_executeCommand {
  Metadata: {
    parentMetric: 'vscode_executeCommand',
    command: 'aws.amazonq.toggleCodeSuggestion',
    source: 'commandPalette',
    duration: '3',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:18:25.391 [debug] telemetry: vscode_executeCommand {
  Metadata: {
    command: 'aws.amazonq.toggleCodeSuggestion.commandPalette',
    duration: '5',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:18:26.932 [debug] telemetry: collapsing 1 "aws.amazonq.toggleCodeSuggestion.commandPalette" metrics. key={}
2024-05-26 19:18:26.932 [debug] command: running "aws.amazonq.toggleCodeSuggestion.commandPalette" with arguments: []
2024-05-26 19:18:26.932 [debug] telemetry: collapsing 1 "aws.amazonq.toggleCodeSuggestion" metrics. key={ '1': 'source' }
2024-05-26 19:18:26.932 [debug] command: running "aws.amazonq.toggleCodeSuggestion" with arguments: [ 'placeholder**', 'commandPalette' ]
2024-05-26 19:18:26.935 [debug] telemetry: aws_modifySetting {
  Metadata: {
    settingId: 'codewhisperer_autoSuggestionActivation',
    settingState: 'Activated',
    duration: '3',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: false
}
Amazon Q: Sign Out 
2024-05-26 19:18:48.772 [debug] command: running "aws.amazonq.signout.commandPalette" with arguments: []
2024-05-26 19:18:48.773 [debug] command: running "aws.amazonq.signout" with arguments: [ 'placeholder**', 'commandPalette' ]
2024-05-26 19:18:48.773 [info] auth: logout
2024-05-26 19:18:48.779 [info] auth: Invalidating connection: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:48.796 [debug] SSO token cache: loaded key: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:48.796 [info] current client registration id=BKZm_Lf95sS6wrGZnexbbHVzLWVhc3QtMQ, 
    expires at Tue Aug 20 2024 15:10:29 GMT-0700 (Pacific Daylight Time), 
    key = 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.118 [warning] credentials (sso): invalidating stored token: Session token not found or invalid
2024-05-26 19:18:49.118 [info] SsoAccessTokenProvider invalidate token and registration
2024-05-26 19:18:49.123 [debug] SSO token cache: deleted (reason: SsoAccessTokenProvider.invalidate()) key: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.127 [debug] auth: SSO registration cache: deleted (reason: SsoAccessTokenProvider.invalidate()) key: {"startUrl":"https://amzn.awsapps.com/start","region":"us-east-1","scopes":["codewhisperer:completions","codewhisperer:analysis","codewhisperer:conversations","codewhisperer:transformations","codewhisperer:taskassist"]}
2024-05-26 19:18:49.127 [warning] auth: failed to logout of connection "06f56967-f6e1-47f0-9ff2-5e95a9b93d10": UnauthorizedException: Session token not found or invalid
2024-05-26 19:18:49.127 [info] SsoAccessTokenProvider invalidate token and registration
2024-05-26 19:18:49.133 [debug] SSO token cache: file not found key: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.133 [debug] auth: SSO registration cache: file not found key: {"startUrl":"https://amzn.awsapps.com/start","region":"us-east-1","scopes":["codewhisperer:completions","codewhisperer:analysis","codewhisperer:conversations","codewhisperer:transformations","codewhisperer:taskassist"]}
2024-05-26 19:18:49.133 [info] auth: Updating connection state of 06f56967-f6e1-47f0-9ff2-5e95a9b93d10 to invalid
2024-05-26 19:18:49.146 [info] codewhisperer: active connection changed
2024-05-26 19:18:49.146 [info] secondaryAuth: connectionId=06f56967-f6e1-47f0-9ff2-5e95a9b93d10, connectionStatus=invalid
2024-05-26 19:18:49.146 [info] codewhisperer: connection states
    connection isValid=false,
    connection isValidCodewhispererCoreConnection=true,
    connection isExpired=true,
    secondaryAuth isExpired=true,
    connection isUndefined=false
2024-05-26 19:18:49.146 [info] codewhisperer: connection changed to invalid: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.146 [info] toolkitApi: set connection 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.149 [info] secondaryAuth: connectionId=06f56967-f6e1-47f0-9ff2-5e95a9b93d10, connectionStatus=undefined
2024-05-26 19:18:49.150 [info] codewhisperer: connection states
    connection isValid=true,
    connection isValidCodewhispererCoreConnection=true,
    connection isExpired=false,
    secondaryAuth isExpired=false,
    connection isUndefined=false
2024-05-26 19:18:49.150 [debug] amazonq: Fetching feature configs
2024-05-26 19:18:49.154 [info] toolkitApi: delete connection 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.160 [debug] SSO token cache: read failed (file not found) key: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.160 [info] current client registration id=undefined, 
    expires at undefined, 
    key = 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.160 [info] auth: Handling invalid credentials of connection: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.160 [info] auth: Updating connection state of 06f56967-f6e1-47f0-9ff2-5e95a9b93d10 to invalid
2024-05-26 19:18:49.160 [error] CodeWhisperer: Error when fetching feature configs Error: Profile does not exist: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10 Profile does not exist: 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.160 [debug] CodeWhisperer: Current feature configs: {NewEOS: TREATMENT, 17B: DEFAULT}
2024-05-26 19:18:49.167 [info] codewhisperer: active connection changed
2024-05-26 19:18:49.168 [info] codewhisperer: connection states
    connection isValid=false,
    connection isValidCodewhispererCoreConnection=false,
    connection isExpired=false,
    secondaryAuth isExpired=false,
    connection isUndefined=true
2024-05-26 19:18:49.168 [info] codewhisperer: active connection changed
2024-05-26 19:18:49.168 [debug] telemetry: collapsing 1 "aws.amazonq.focusChat" metrics. key={ '1': 'source' }
2024-05-26 19:18:49.168 [debug] command: running "aws.amazonq.focusChat" with arguments: [ 'placeholder**', 'commandPalette' ]
2024-05-26 19:18:49.181 [debug] telemetry: vscode_executeCommand {
  Metadata: {
    parentMetric: 'vscode_executeCommand',
    command: 'aws.amazonq.signout',
    source: 'commandPalette',
    duration: '410',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'not-set'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:18:49.181 [debug] telemetry: vscode_executeCommand {
  Metadata: {
    command: 'aws.amazonq.signout.commandPalette',
    duration: '412',
    result: 'Succeeded',
    awsAccount: 'not-set',
    awsRegion: 'not-set'
  },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:18:49.182 [debug] telemetry: auth_signInPageOpened {
  Metadata: { result: 'Succeeded', awsAccount: 'not-set', awsRegion: 'not-set' },
  Value: 1,
  Unit: 'None',
  Passive: true
}
2024-05-26 19:18:49.190 [info] toolkitApi: connection delete callback 06f56967-f6e1-47f0-9ff2-5e95a9b93d10
2024-05-26 19:18:49.275 [debug] Registered event handler for: onActiveConnectionModified
2024-05-26 19:18:49.275 [debug] Webview called command "refreshAuthState" with args: []
2024-05-26 19:18:49.283 [debug] Webview called command "getAuthState" with args: []
2024-05-26 19:18:49.286 [debug] Webview called command "getDefaultStartUrl" with args: []
2024-05-26 19:18:49.289 [debug] Webview called command "getRegions" with args: []
2024-05-26 19:18:49.289 [warning] AwsContext: no default region in credentials profile, falling back to us-east-1:
2024-05-26 19:18:49.290 [debug] Webview called command "fetchConnections" with args: []
2024-05-26 19:18:49.290 [debug] Webview called command "resetStoredMetricMetadata" with args: []
2024-05-26 19:18:49.668 [debug] Webview called command "refreshAuthState" with args: []
2024-05-26 19:18:49.669 [debug] Webview called command "getAuthState" with args: []
2024-05-26 19:19:02.741 [info] telemetry: sent batch (size=20)
2024-05-26 19:19:02.997 [info] telemetry: sent batch (size=15)

@ivikash ivikash marked this pull request as draft May 29, 2024 21:07
@ivikash ivikash force-pushed the feat/amazon-q-commands branch 2 times, most recently from 314f0ae to 5234f57 Compare May 29, 2024 21:44
@ivikash
Copy link
Member Author

ivikash commented May 29, 2024

Screen.Recording.2024-05-29.at.2.34.05.PM.mov

@ivikash ivikash marked this pull request as ready for review May 29, 2024 21:51
justinmk3
justinmk3 reviewed May 29, 2024
View reviewed changes
packages/amazonq/package.json Outdated
"enablement": "aws.codewhisperer.connected"
},
{
"command": "aws.amazonq.toggleCodeSuggestion.commandPalette",
Copy link
Contributor

@justinmk3 justinmk3 May 29, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we can avoid these .commandPalette cases and re-use the existing commands.

Setting source may require some thought, but it's less important than avoiding lots of duplicate command defininitions.

justinmk3
justinmk3 reviewed May 29, 2024
View reviewed changes
packages/core/src/codewhisperer/commands/basicCommands.ts Outdated
Comment on lines 67 to 69
isSuggestionsEnabled
? void showTimedMessage('Amazon Q: Auto-Suggestions are currently running.', MessageTimeOut)
: void showTimedMessage('Amazon Q: Auto-Suggestions are currently paused.', MessageTimeOut)
Copy link
Contributor

@justinmk3 justinmk3 May 29, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using a ternary may be clearer and less verbose

void showTimedMessage(`... ${isSuggestionsEnabled ? ... : ...}`)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this kind of message is probably more appripriate as a status message rather than a popup

@ivikash
Copy link
Member Author

ivikash commented May 30, 2024 •
edited

TODO:

  • Update Copy for Error Messages for Select Customization and Toggle Auto-Scans when user is connected via AWS builder Id.
  • Set proper source in compositeKey for Telemetry.

@ivikash ivikash force-pushed the feat/amazon-q-commands branch 3 times, most recently from b73cecf to 10c01f7 Compare June 4, 2024 19:23
justinmk3
justinmk3 reviewed Jun 5, 2024
View reviewed changes
packages/core/src/codewhisperer/commands/basicCommands.ts Outdated
@@ -93,6 +107,12 @@ export const toggleCodeScans = Commands.declare(
})

await vscode.commands.executeCommand('aws.amazonq.refreshStatusBar')
void showTimedMessage(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
void showTimedMessage(
void vscode.window.setStatusBarMessage(

justinmk3
justinmk3 reviewed Jun 5, 2024
View reviewed changes
packages/core/src/codewhisperer/commands/types.ts
Comment on lines 16 to +20
export const firstStartUpSource = ExtStartUpSources.firstStartUp
/** Indicates a CodeWhisperer command was executed as a result of selecting an ellipses menu item */
export const cwEllipsesMenu = 'ellipsesMenu'
/** Indicates a CodeWhisperer command was executed from the command palette */
export const commandPalette = 'commandPalette'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these constants should live in packages/core/src/shared/telemetry/telemetry.ts or perhaps a new packages/core/src/shared/telemetry/constants.ts file.

however, that can be done in a separate PR, to unblock this PR.

@ivikash
feat(amazonq): add commands to command palette
06ada04 
Commands Added
- Amazon Q: Focus on Chat View
- Amazon Q: Open Code Reference Log
- Amazon Q: Select Customizations
- Amazon Q: Toggle Auto-Scans
- Amazon Q: Toggle Auto-Suggestions
- Amazon Q: Try inline suggestion example
- Amazon Q: Sign out

Notes:
- Amazon Q commands are now displayed when the user is logged in.
- Auto-Scans and Select Customizations commands are enabled when the user is not logged in using
  builder-id
@justinmk3 justinmk3 merged commit cd9be21 into aws:master Jun 5, 2024
12 of 14 checks passed
@ivikash ivikash deleted the feat/amazon-q-commands branch June 5, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk3 justinmk3 justinmk3 approved these changes

@leigaol leigaol Awaiting requested review from leigaol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivikash @justinmk3