Skip to content

feat(signature-v4-multi-region): add support for sigv4a package #6267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

siddsriv
Copy link
Contributor

@siddsriv siddsriv commented Jul 10, 2024

Issue

Internal JS-5146

Description

Add support in signature-v4-multi-region for the @smithy/signature-v4a package.
Partner PR: smithy-lang/smithy-typescript#1319

To-Do

Testing

  • SignatureV4MultiRegion:

-- Unit tests

 ✓ src/SignatureV4MultiRegion.spec.ts (11)
   ✓ SignatureV4MultiRegion (11)
     ✓ should sign with SigV4 signer
     ✓ should presign with SigV4 signer
     ✓ should presign with SigV4 signer
     ✓ should sign with SigV4a signer if signingRegion is '*'
     ✓ should use SignatureV4a if CrtSignerV4 is not available
     ✓ should throw an error for presignWithCredentials with star region
     ✓ should throw when presigning with signingRegion '*' if CRT is NOT available
     ✓ should throw when presigning with signingRegion '*' in non-node runtime (CRT unavailable)
     ✓ should throw an error if neither CrtSignerV4 nor JsSigV4aSigner is available in node runtime
     ✓ should throw an error if JsSigV4aSigner is not available in non-node runtime
     ✓ should use JsSigV4aSigner in non-node runtime

 Test Files  1 passed (1)
      Tests  11 passed (11)

-- Browser test

 ✓ src/SignatureV4MultiRegion.browser.spec.ts (2)
   ✓ SignatureV4MultiRegion (Browser Bundle SigV4a Test) (2)
     ✓ should use SigV4a for the request when signingRegion is '*' (JS implementation is available in bundle)
     ✓ should throw error when signingRegion is '*' and JS implementation is NOT available (Covered in Unit Tests)

 Test Files  1 passed (1)
      Tests  2 passed (2)

-- E2E tests

✓ src/cloudfront-kvs-sigv4a.e2e.spec.ts (2) 7644ms
 ✓ src/eventbridge-sigv4a-put-api.e2e.spec.ts (2) 18268ms

 Test Files  2 passed (2)
      Tests  4 passed (4)

-- clients/client-s3/test/e2e/s3-mrap-sigv4a.e2e.spec.ts:

 ✓ test/e2e/s3-mrap-sigv4a.e2e.spec.ts (1) 1013ms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested a review from a team as a code owner July 10, 2024 18:25
@siddsriv siddsriv marked this pull request as draft July 10, 2024 18:35
@siddsriv siddsriv marked this pull request as ready for review July 11, 2024 17:16
@kuhe kuhe self-requested a review July 15, 2024 16:48
@siddsriv siddsriv marked this pull request as draft July 31, 2024 16:09
@Lemour-sudo
Copy link

Do we have any idea when this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants