Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows users to configure contentType for BlockingInputStreamAsyncRequestBody #5234

Merged
merged 5 commits into from
Jun 5, 2024

Conversation

chaykin
Copy link
Contributor

@chaykin chaykin commented May 18, 2024

Motivation and Context

Implementation a feature, #5143 described

Modifications

Added method BlockingInputStreamAsyncRequestBody.Builder#contentType

Testing

Modifications does not affect any tests

Types of changes

It is only exposing the ability to set a value. Change is backward compatible and does not change the functionality of any existing code

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@chaykin chaykin requested a review from a team as a code owner May 18, 2024 08:45
@chaykin chaykin force-pushed the master branch 2 times, most recently from 765926f to 50a1822 Compare May 28, 2024 03:49
@chaykin
Copy link
Contributor Author

chaykin commented Jun 5, 2024

  • New-change file updated
  • Test for create BlockingInputStreamAsyncRequestBody by builder added
  • Integration test for putObject by S3AsyncClient with custom content type added

I'm not sure what kind of tests must be here...

@davidh44
Copy link
Contributor

davidh44 commented Jun 5, 2024

Look good, thanks! Updated the tests, triggering CI checks

@davidh44
Copy link
Contributor

davidh44 commented Jun 5, 2024

@all-contributors please add @chaykin for code

Copy link
Contributor

@davidh44

I've put up a pull request to add @chaykin! 🎉

@davidh44 davidh44 enabled auto-merge (squash) June 5, 2024 20:15
Copy link

sonarcloud bot commented Jun 5, 2024

@davidh44 davidh44 merged commit 74f9474 into aws:master Jun 5, 2024
11 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants