feat: Migrate from cyclonus to policy-assistant for network policy testing#508
Open
dap0am wants to merge 1 commit into
Open
feat: Migrate from cyclonus to policy-assistant for network policy testing#508dap0am wants to merge 1 commit into
dap0am wants to merge 1 commit into
Conversation
…sting Migrate the network policy test suite from cyclonus to policy-assistant, following the upstream migration to kubernetes-sigs/network-policy-api. Changes: - Update test Job to use policy-assistant instead of cyclonus - Update image repository from mfenwick100/cyclonus to registry.k8s.io/networking-e2e-test-images/policy-assistant - Rename functions from run_cyclonus_tests to run_policy_assistant_tests - Add backwards compatibility alias for run_cyclonus_tests - Update service accounts and cluster role bindings - Update documentation to reflect the migration Benefits: - Access to more comprehensive test suite beyond cyclonus - Includes AdminNetworkPolicy tests (may need adaptation for NPA CRDs) - Follows upstream recommendation to use policy-assistant Note: The policy-assistant image should be published to the specified registry. If not available, it can be built from source using the kubernetes-sigs/network-policy-api repository. Resolves aws#507
Contributor
|
@dap0am thanks for the contribution. Can you post the run results as well ? |
Contributor
|
Please add the test results so that we can take the PR forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the network policy test suite from cyclonus to policy-assistant, following the upstream recommendation mentioned in issue #507.
Changes
Test Script Updates (
scripts/lib/tests.sh)policy-assistantinstead ofcyclonusmfenwick100/cyclonus:v0.5.4toregistry.k8s.io/networking-e2e-test-images/policy-assistant:latestrun_cyclonus_tests()torun_policy_assistant_tests()policy-assistantDocumentation Updates (
scripts/README.md)Benefits
Compatibility
run_cyclonus_tests()alias that calls the new functionrun-cyclonus-tests.shcontinue to work without modificationImportant Note
Container Image
The policy-assistant project does not yet have an official published container image. The PR assumes the image will be available at
registry.k8s.io/networking-e2e-test-images/policy-assistant:latest(following the same pattern as cyclonus).Options if image is not available:
See comments in
scripts/lib/tests.shfor details.Testing
Related Issues
Resolves #507
Note: This migration aligns with the upstream evolution where cyclonus functionality has been incorporated into policy-assistant as part of the kubernetes-sigs/network-policy-api project.