Add Libwebsockets to our CI #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2290 +/- ##
==========================================
- Coverage 78.73% 78.71% -0.03%
==========================================
Files 616 616
Lines 107584 107588 +4
Branches 15286 15285 -1
==========================================
- Hits 84707 84686 -21
- Misses 22222 22246 +24
- Partials 655 656 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tests/ci/integration/libwebsockets_patch/libwebsocket_master.patch
Outdated
Show resolved
Hide resolved
justsmth
previously approved these changes
Apr 4, 2025
Comment on lines
5
to
6
| set -ex | ||
|
|
justsmth
approved these changes
Apr 4, 2025
samuel40791765
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2992Description of changes:
Add libwebsockets master to our CI along with a patch file.
The patch file simplifies many of the ifdefs in libwebsockets code that were previously repetitive and convoluted by creating helped macros/simplifying logic. I have tested this variant of libwebsockets locally with AWS-LC and OpenSSL, WolfSSL remains pending.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.