-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[v2] Add support for chunking performance tests #9485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d6765ba
Progress on benchmarks
aemous 03cd651
Update remove prints.
aemous 607df62
Update request time to be more accurate
aemous 957f6ba
Stage architectural changes that allow more complex benchmark suites.
aemous 62a606d
More progress on performance framework.
aemous 5c1ba4f
More updates/questions
aemous bc9ce9b
Add chunking support to performance scripts. Refine performance scrip…
aemous 464143d
Bugfix in chunking code.
aemous 9cce974
Cleanup data files.
aemous 7b1e20b
Update performance tests output format.
aemous 5ce2a28
Clean up performance framework for push.
aemous df46a22
Merge branch 'v2' into perf-tests-v2-github
aemous 4607429
Remove typing
aemous f7d9dc1
Cleanup planned tasks.
aemous 69b0053
Progress towards using decorators to define test cases.
aemous e8635be
Add more vision to the skeleton.
aemous 1368faf
Fix import paths and fix percentage metric name.
aemous 33d89b5
Adjust dimensions JSON format.
aemous 5671a8b
Switch from using binary-content key in file literals for JSON Benchm…
aemous b6032eb
Develop outline for using decorators for defining performance test ca…
aemous 4018ae1
Move all Metric creation to within the Summarizer.
aemous a90b887
Move results processing from suite to a separate class.
aemous 0f4c3e5
Finishing touches on refactoring.
aemous 404f63d
Formatting/linting.
aemous c6899f5
Divide percent by 100. Add missing dimension to s3 mv download,
aemous 20f74b8
Iterated on PR feedback.
aemous File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is anything actually using this? It looks hardcoded below in
_create_file_with_size
andbegin_iteration
.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in line 136 of
simple_stubbed_tests.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I just saw the
w
and thought it was hardcoded, but that's just the fallback.