-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(kinesis): shard-level metrics for stream #34242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
badmintoncryer
wants to merge
4
commits into
aws:main
Choose a base branch
from
badmintoncryer:desired-shard-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+105
−0
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
48 changes: 48 additions & 0 deletions
48
...-cdk-testing/framework-integ/test/aws-kinesis/test/integ.stream-shard-level-monitoring.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import { App, Stack } from 'aws-cdk-lib'; | ||
import * as kinesis from 'aws-cdk-lib/aws-kinesis'; | ||
import { ExpectedResult, IntegTest } from '@aws-cdk/integ-tests-alpha'; | ||
import { RemovalPolicies } from '../../../../../aws-cdk-lib/core/lib/removal-policies'; | ||
|
||
const app = new App(); | ||
const stack = new Stack(app, 'kinesis-stream-shard-level-monitoring-stack'); | ||
|
||
const explicitStream = new kinesis.Stream(stack, 'ExplicitStream', { | ||
shardLevelMetrics: [ | ||
kinesis.ShardLevelMetrics.INCOMING_BYTES, | ||
kinesis.ShardLevelMetrics.INCOMING_RECORDS, | ||
kinesis.ShardLevelMetrics.ITERATOR_AGE_MILLISECONDS, | ||
kinesis.ShardLevelMetrics.OUTGOING_BYTES, | ||
kinesis.ShardLevelMetrics.OUTGOING_RECORDS, | ||
kinesis.ShardLevelMetrics.WRITE_PROVISIONED_THROUGHPUT_EXCEEDED, | ||
kinesis.ShardLevelMetrics.READ_PROVISIONED_THROUGHPUT_EXCEEDED, | ||
], | ||
}); | ||
|
||
const allStream = new kinesis.Stream(stack, 'AllStream', { | ||
shardLevelMetrics: [kinesis.ShardLevelMetrics.ALL], | ||
}); | ||
|
||
RemovalPolicies.of(stack).destroy(); | ||
|
||
const integ = new IntegTest(app, 'integ-kinesis-stream-consumer', { | ||
testCases: [stack], | ||
}); | ||
|
||
const streams = [explicitStream, allStream]; | ||
streams.forEach((stream) => { | ||
integ.assertions.awsApiCall('Kinesis', 'describeStream', { | ||
StreamName: stream.streamName, | ||
}).expect(ExpectedResult.objectLike({ | ||
StreamDescription: { | ||
ShardLevelMetrics: [ | ||
'IncomingBytes', | ||
'IncomingRecords', | ||
'IteratorAgeMilliseconds', | ||
'OutgoingBytes', | ||
'OutgoingRecords', | ||
'WriteProvisionedThroughputExceeded', | ||
'ReadProvisionedThroughputExceeded', | ||
], | ||
}, | ||
})); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,53 @@ const WRITE_OPERATIONS = [ | |
'kinesis:PutRecords', | ||
]; | ||
|
||
/** | ||
* Enhanced shard-level metrics | ||
* | ||
* @see https://docs.aws.amazon.com/streams/latest/dev/monitoring-with-cloudwatch.html#kinesis-metrics-shard | ||
*/ | ||
export enum ShardLevelMetrics { | ||
/** | ||
* The number of bytes successfully put to the shard over the specified time period. | ||
*/ | ||
INCOMING_BYTES = 'IncomingBytes', | ||
|
||
/** | ||
* The number of records successfully put to the shard over the specified time period. | ||
*/ | ||
INCOMING_RECORDS = 'IncomingRecords', | ||
|
||
/** | ||
* The age of the last record in all GetRecords calls made against a shard, measured over the specified time period. | ||
*/ | ||
ITERATOR_AGE_MILLISECONDS = 'IteratorAgeMilliseconds', | ||
|
||
/** | ||
* The number of bytes retrieved from the shard, measured over the specified time period. | ||
*/ | ||
OUTGOING_BYTES = 'OutgoingBytes', | ||
|
||
/** | ||
* The number of records retrieved from the shard, measured over the specified time period. | ||
*/ | ||
OUTGOING_RECORDS = 'OutgoingRecords', | ||
|
||
/** | ||
* The number of GetRecords calls throttled for the shard over the specified time period. | ||
*/ | ||
READ_PROVISIONED_THROUGHPUT_EXCEEDED = 'ReadProvisionedThroughputExceeded', | ||
|
||
/** | ||
* The number of records rejected due to throttling for the shard over the specified time period. | ||
*/ | ||
WRITE_PROVISIONED_THROUGHPUT_EXCEEDED = 'WriteProvisionedThroughputExceeded', | ||
|
||
/** | ||
* All metrics | ||
*/ | ||
ALL = 'ALL', | ||
} | ||
|
||
/** | ||
* A Kinesis Stream | ||
*/ | ||
|
@@ -784,6 +831,15 @@ export interface StreamProps { | |
* @default RemovalPolicy.RETAIN | ||
*/ | ||
readonly removalPolicy?: RemovalPolicy; | ||
|
||
/** | ||
* A list of shard-level metrics in properties to enable enhanced monitoring mode. | ||
* | ||
* @see https://docs.aws.amazon.com/streams/latest/dev/monitoring-with-cloudwatch.html#kinesis-metrics-shard | ||
* | ||
* @default undefined - AWS Kinesis default is disabled | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Default behavior is described in this documentation.
|
||
*/ | ||
readonly shardLevelMetrics?: ShardLevelMetrics[]; | ||
} | ||
|
||
/** | ||
|
@@ -861,6 +917,7 @@ export class Stream extends StreamBase { | |
retentionPeriodHours, | ||
shardCount, | ||
streamEncryption, | ||
desiredShardLevelMetrics: props.shardLevelMetrics, | ||
...(props.streamMode !== undefined | ||
? { | ||
streamModeDetails: { streamMode: props.streamMode }, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid values are described in this documentation.