feat(backup): add indexActions prop to BackupPlanRule #34051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
github-actions
bot
added
feature-request
aws-cdk-automation
previously requested changes
Apr 4, 2025
georeeve
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #34050.
Reason for this change
Allows Backup indexes to be configured on specific resource types.
Description of changes
I have matched the CFN schema by creating
BackupPlanIndexActionPropsandIndexActionResourceType. I'm not sure if it makes sense forindexActionsto be an array in its current state, but that's what CFN requires and maybe additional features are planned to utilise multiple actions.Describe any new or updated permissions being added
N/A
Description of how you validated changes
I have added a unit test, updated the backup integ test and deployed to verify the changes in the AWS console.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license