feat(amplify): add compute role support for Amplify app #33962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
effort/medium
aws-cdk-automation
previously requested changes
Mar 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33962 +/- ##
=======================================
Coverage 83.98% 83.98%
=======================================
Files 120 120
Lines 6976 6976
Branches 1178 1178
=======================================
Hits 5859 5859
Misses 1005 1005
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
1 task
mergify bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
…ld in `customRule` (#33973) ### Issue # (if applicable) N/A I found this problem while working on #33962. ### Reason for this change Re-running `packages/@aws-cdk/aws-amplify-alpha/test/integ.app.ts`, got the following error: ```sh Resource handler returned message: "Invalid request provided: Status field in rewrite custom rules should not be empty (Service: Amplify, Status Code: 400, Request ID: 3f3694f1-3eeb-4af3-8cdf-8b77b6387e57) (SDK Attempt Count: 1)" (RequestToken: 5748aef8-c0e1-1a1d-ab27-1bab938e0bd3, HandlerErrorCode: InvalidRequest) ``` If `status` is omitted in `customRules`, `App` cannot be deployed. ### Description of changes Specify `status` property in integ test. ### Describe any new or updated permissions being added N/A ### Description of how you validated changes Re-ran integ test. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
mazyu36
commented
Apr 8, 2025
| /** | ||
| * The IAM role for an SSR app. | ||
| * The Compute role allows the Amplify Hosting compute service to securely access specific AWS resources based on the role's permissions. | ||
| * @default undefined - a new role is created when `platform` is `Platform.WEB_COMPUTE` or `Platform.WEB_DYNAMIC`, otherwise no compute role |
There was a problem hiding this comment.
Since the compute role is used when SSR apps access AWS resources, I thought it would be more user-friendly to auto-generate it.
Please let me know if you have any opinions on this.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #33882 .
Reason for this change
To support compute role for SSR app.
Description of changes
computeRoleproperty.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Add unit tests and an integ test.
Checklist
BREAKING CHANGE: A compute role is created when
platformisPlatform.WEB_COMPUTEorPlatform.WEB_DYNAMIC.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license