Fix IAM permission issues on creation of new task #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ws](https://github.com/websockets/ws) from 7.4.5 to 7.5.3. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.4.5...7.5.3) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.16.4 to 4.16.7. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.16.4...4.16.7) --- updated-dependencies: - dependency-name: browserslist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.5.1 to 1.5.3. - [Release notes](https://github.com/unshiftio/url-parse/releases) - [Commits](unshiftio/url-parse@1.5.1...1.5.3) --- updated-dependencies: - dependency-name: url-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tar](https://github.com/npm/node-tar) from 6.1.0 to 6.1.8. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.0...v6.1.8) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…arn/source/constructs/path-parse-1.0.7 chore(deps): bump path-parse from 1.0.6 to 1.0.7 in /source/constructs
…arn/source/constructs/ws-7.5.3 chore(deps): bump ws from 7.4.5 to 7.5.3 in /source/constructs
…arn/source/constructs/browserslist-4.16.7 chore(deps): bump browserslist from 4.16.4 to 4.16.7 in /source/constructs
…arn/source/portal/url-parse-1.5.3 chore(deps): bump url-parse from 1.5.1 to 1.5.3 in /source/portal
…arn/source/portal/tar-6.1.8 chore(deps): bump tar from 6.1.0 to 6.1.8 in /source/portal
Bumps [tar](https://github.com/npm/node-tar) from 6.1.8 to 6.1.11. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.8...v6.1.11) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…arn/source/portal/tar-6.1.11 chore(deps): bump tar from 6.1.8 to 6.1.11 in /source/portal
fix: update ui security 0910
**What changes does this introduce** - Adds additional IAM permission `ecs:CreateServiceLinkedRole` to existing policy statement within `APICfnWorkflowTaskFnPolicy`. - Creates new policy statement within `APICfnWorkflowTaskFnPolicy` to grant the `DataTransferHub-APICfnWorkflowCreateTaskCfnFnServi-<ID>` role `iam:CreateServiceLinkedRole` permissions to the `AWSServiceRoleForAutoScaling` resource. **Why are these changes necessary?** Without these permissions, the CloudFormation template deployed on creation of a new data transfer task will not successfully deploy and the permissions need to be manually added to the `APICfnWorkflowTaskFnPolicy` attached to the `DataTransferHub-APICfnWorkflowCreateTaskCfnFnServi-<ID>` role.
|
Hi @mang0kitty , thank you for your contribution, we will check and test the code first. |
chenhaiyun
pushed a commit
that referenced
this pull request
Sep 26, 2021
|
@mang0kitty, Thanks you for contributing the code to solve this problem. Could you please resolve the conflict and we will merge. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
ecs:CreateServiceLinkedRoleto existing policy statement withinAPICfnWorkflowTaskFnPolicy.APICfnWorkflowTaskFnPolicyto grant theDataTransferHub-APICfnWorkflowCreateTaskCfnFnServi-<ID>roleiam:CreateServiceLinkedRolepermissions to theAWSServiceRoleForAutoScalingresource.Why are these changes necessary?
Without these permissions, the CloudFormation template deployed on creation of a new data transfer task will not successfully deploy and the permissions need to be manually added to the
APICfnWorkflowTaskFnPolicyattached to theDataTransferHub-APICfnWorkflowCreateTaskCfnFnServi-<ID>role.