Fixed boolean for property "Blackhole" #1
Conversation
|
either works. yes/no or true/false. Is there a reason you prefer true? I just got used to saying 'yes' as it was an option i wanted. |
|
Sorry, my bad then. It did not work when I applied it and threw errors (didn't document those, would need to do it again). My interpretation of these error messages where there's a problem with yes/no. And after I changed this the thing ran flawlessly. That's why I tried to contribute with this fix - but I'm certainly no expert here. |
|
no problem at all. i'd be really interested in what the errors were. I've just been working with a template that has about 15 boolean options in it, and i've used yes or no throughout without an issue. What region were you in? If there is a way to duplicate the issue, that would be awesome...always happy to improve my hacked code :-) And thanks for commenting. Whether or not there is a gotcha, its nice to see the blog and code being looked at. |
|
Ok, just had a look at the stack events in CloudFormation, here's what it reads (Timestamp, Logical ID, Status, Status reason):
After this a few depending resources fail to create and eventually the stack does a rollback. I tested this in eu-west-1 (Ireland), three times. Hope that helps? |
|
Thanks Marco, I will have a look in the next couple of days and come back to you.
thanks
perry
From: Marco Castagna <[email protected]>
Reply-To: aws-samples/transit-gateway-single-exit-point <[email protected]>
Date: Tuesday, 10 December 2019 at 09:06
To: aws-samples/transit-gateway-single-exit-point <[email protected]>
Cc: "Wald, Perry" <[email protected]>, Comment <[email protected]>
Subject: Re: [aws-samples/transit-gateway-single-exit-point] Fixed boolean for property "Blackhole" (#1)
Ok, just had a look at the stack events in CloudFormation, here's what it reads (Timestamp, Logical ID, Status, Status reason):
* 2019-10-30 16:39:51 UTC+0100 AppBlackhole172Route CREATE_FAILED Property validation failure: [Value of property {/Blackhole} does not match type {Boolean}]
* 2019-10-30 16:39:51 UTC+0100 AppBlackhole10Route CREATE_FAILED Property validation failure: [Value of property {/Blackhole} does not match type {Boolean}]
After this a few depending resources fail to create and eventually the stack does a rollback.
I tested this in eu-west-1 (Ireland), three times. Hope that helps?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#1?email_source=notifications&email_token=ANEWQJKHEOFCRR2KAHOKSSLQX5LYBA5CNFSM4JG44P4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGOPX6A#issuecomment-563936248>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANEWQJKNW7DOMJ6JJRUMJDTQX5LYBANCNFSM4JG44P4A>.
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
Amazon Web Services EMEA Sarl, UK Branch, 1 Principal Place, Worship Street, London, EC2A 2FA, United Kingdom, registered in England and Wales, UK Establishment No. BR019315
|
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.