fix: StackSet preflight — check both service-managed and self-managed principals#84
Merged
Merged
Conversation
…principals The StackSet trusted access preflight checked only `stacksets.cloudformation.amazonaws.com` (self-managed) but Control Tower orgs use `member.org.stacksets.cloudformation.amazonaws.com` (service-managed). Changed to `contains(ServicePrincipal,'stacksets.cloudformation')` to match both. Also upgraded from warning to blocking error — without trusted access, StackSet creation fails with a cryptic CFN error. CT3 finding: C03/C04 StackSet tests failed because the sandbox has service-managed only; the preflight didn't catch it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stacksets.cloudformation.amazonaws.com(self-managed)member.org.stacksets.cloudformation.amazonaws.com(service-managed)contains(ServicePrincipal,'stacksets.cloudformation')to match bothContext
CT3 collision tests C03/C04 failed because the sandbox has service-managed StackSets only. The preflight showed a warning but didn't block — the deploy proceeded and failed with a cryptic CFN error. Customers in the same setup would hit the same issue.
Test plan
member.org.stacksets.cloudformation.amazonaws.comenabled🤖 Generated with Claude Code