fix(configurator): rename Upgrade-mode output to upgrade.sh (v20.5.4)#48
Merged
fix(configurator): rename Upgrade-mode output to upgrade.sh (v20.5.4)#48
Conversation
…(v20.5.4) The configurator's Upgrade-mode flow (replaces Lambda/IAM/EventBridge to the latest template version) and its Editor-mode flow (add/remove accounts from scope without redeploying) both generated a file named update.sh. Customers running both got two downloads with the same filename and no way to tell which was which by name alone. Changes: - Upgrade-mode output renamed update-<mpe>.sh → upgrade-<mpe>.sh - Editor-mode output unchanged (still update-<mpe>.sh) - Split shared i18n keys: ui_editor_generate/download stay on Editor tab; new ui_upgrade_generate/ui_upgrade_download added for Upgrade tab (English only; 7 non-English translations left as follow-up, same pattern as ui_update_confirm_risk in v20.5.3) - Split shared window globals: _editorScript/_editorMpe scoped to Editor mode; Upgrade mode uses new _upgradeScript/_upgradeMpe. Prevents cross-tab data contamination if customer toggles between modes - Visible copy (ui_update_info, ui_update_info_detail) and UPGRADE INSTRUCTIONS heredoc now say upgrade.sh - YAML comment and configurator inline-template comment bumped from "read by update.sh" → "read by upgrade.sh" - Version bumped across 4 canonical sites (Description, MapVersion default, TEMPLATE_VERSION constant, TemplateVersion Output) + configurator TEMPLATE_VERSION + VERSION_HISTORY entry - CHANGELOG v20.5.4 entry added; VERSIONING example bumped No runtime Lambda change; YAML byte-identical to v20.5.3 except for the four version stamps + one comment. No breaking change — customer who downloaded update.sh at v20.5.3 still runs fine; it behaves identically to upgrade.sh at v20.5.4. Layer 1 local: sync-check ✅, lint_cfn_correctness ✅, lint_event_prefixes ✅, lint_shell_injection ✅, HTML well-formed ✅, YAML Lambda py_compile ✅, cfn-lint ✅. Co-authored-by: Jin Shan Ng <ngjinshan99@gmail.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the configurator's Upgrade-mode generator output from
update.shtoupgrade.sh. Editor-mode (day-2 account scope) continues to outputupdate.sh. Eliminates the filename collision that Jin flagged in PR #27.Motivation
Today the configurator has two distinct flows that both produce a file named
update.sh:Customers running both flows get two downloads with the same filename and no way to distinguish them.
Scope
update-<mpe>.sh→upgrade-<mpe>.shupdate-<mpe>.sh)ui_upgrade_generate/ui_upgrade_downloadfor Upgrade tab;ui_editor_*keys keep serving Editor tab_upgradeScript/_upgradeMpefor Upgrade tab;_editor*keep serving Editor tab (prevents cross-tab contamination when customer toggles modes)ui_update_info,ui_update_info_detail) and the UPGRADE INSTRUCTIONS heredoc now sayupgrade.sht()fallback (same pattern asui_update_confirm_riskin v20.5.3 — follow-up for translation sprint)Compatibility
update.shfrom v20.5.3 on disk can run it; behavior is identical to v20.5.4'supgrade.sh.Supersedes
Part of Jin's PR #27 — specifically the
update.sh→upgrade.shrename (commitcc44ac7). Jin's broader PR #27 is being split into this narrow rename + a separate PR for the new delete-flow (item 2/4/5/6/8 of Wave 0). Item 1 (--use-previous-parametersfix) already shipped as PR #47.Test plan
sync-check.py,lint_cfn_correctness.py,lint_event_prefixes.py,lint_shell_injection.py, HTML well-formedness, YAML Lambdapy_compile,cfn-lintupgrade-<mpe>.shupdate-<mpe>.shCo-authored-by: Jin Shan Ng (cc44ac7 on PR #27).
🤖 Generated with Claude Code