Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GPU accounting for SMHP #462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

add GPU accounting for SMHP #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...chitectures/5.sagemaker-hyperpod/LifecycleScripts/base-config/setup_mariadb_accounting.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ JobAcctGatherFrequency=30
AccountingStorageType=accounting_storage/slurmdbd
AccountingStorageHost=$DBD_HOST
AccountingStoragePort=6819
AccountingStorageTRES=gres/gpu
GresTypes=gpu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me copy paste my comment from slack.

GresTypes=gpu doesn't allow customers to resume a faulty job if they want. AutoResume plugin will always requeue a job in this case. Personally, I'm fine with this because result is the same -> we recover a faulty job from hardware failure. But this is a behaviour change, for existing customers. We can initiate discussion if gres should be on by default, because in my opinion it has more benefits for customers than resuming jobs.

We have CPU only instances. Even trn1/trn2 are marked as "CPU only" and don't have any Gres attached now, and they defenitely will not have gpus. Maybe it make sense to configure these values via ClusterAgent depends on instance types in the cluster.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussing internally on gres setup.

EOL
}

Expand Down