-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update organization and tag to V1 #150
base: main
Are you sure you want to change the base?
Conversation
Please stop numbering things. This is useless and will create plenty of challenges to add and remove things. Why AMI is 1. and container 2. what's the logic? |
Here is my proposal
|
@awsankur if you can comment here. |
I like this structure. A couple of comments:
Within each FRAMEWORK_NAME we can have Dockerfiles, sbatch scripts and kubernetes yaml and other necessary files for each model name Thoughts? |
Love 2. organize by "vendor" For 1. don't think we'll go outside grafana+prometheus at this point. We can organize the observability section by orchestrator for since the deployment and setup will be different. |
@mhuguesaws how about CloudWatch or profilers like Nsight? |
Profiler in profiler ;) |
We should add Nsight |
profilers. |
I was wondering if |
11abd11
to
a6ffefc
Compare
44e448e
to
1209815
Compare
Addresses #149
Update naming for Jax, update naming for single digit examples, new directory for best practices (EFA cheat sheet was in architectures).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.