Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: endpoint name issues for dkr.api and others #30

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DannyBlazejczak
Copy link

Issue #, if available:

Description of changes:

This is fixing 2 issues with the endpoints:

Issue 1:

  • endpoint for ecr.dkr was incorrectly named ecr-dkr, it results in this error:
    "The Vpc Endpoint Service 'com.amazonaws.ap-southeast-2.ecr-dkr' does not exist (Service: Ec2, Status Code: 400 ..."
    Solution 1:
  • It is incorrect to assume that all endpoint service names use a dash, e.g. these services all have dots, not dashes:
    ecr.drk, ecr.api, airflow.api, airflow.env, airflow.ops, sagemaker.api, sagemaker.runtime-fips
    There are no fast rules here, take the input from the configuration instead.

Issue 2:

  • For the privateDnsName using 'ecr.dkr' resolved wrongly to '*.dkr.ecr.ap-southeast-2.amazonaws.com.', and results in this error:
    "Invalid request provided: Creation of hosted zone with a wildcard domain name is not supported. (Service: Route53, Status Code: 400"
    Soltion 2: (did not work)
  • The tool discoverEndpoints was ran but did not update the privateDnsName for the endpoint.
    Solution 2b:
  • To remove the *. prefix which is invalid for DNS names. There are many endpoints with this issue.
  • Hence removing the *. in front of the dns name.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant