Fixed QS Data Source policy name collision (#649)

aws-samples · Oct 23, 2023 · c0eb5b3 · c0eb5b3
1 parent f276dbd
commit c0eb5b3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -57,3 +57,4 @@ venv.bak/
 
 #Local dev and testing files
 cfn-templates/parameters.local
+sandbox/
diff --git a/cfn-templates/cid-cfn.yml b/cfn-templates/cid-cfn.yml
@@ -432,6 +432,11 @@ Resources:
           - Id: DeleteContent
             Status: 'Enabled'
             ExpirationInDays: 7
+    Metadata:
+      cfn-lint:
+        config:
+          ignore_checks:
+            - W3045 #Consider using AWS::S3::BucketPolicy instead of AccessControl; standard Athena results setup
 
   MyAthenaWorkGroup:
     Type: AWS::Athena::WorkGroup
@@ -1075,7 +1080,7 @@ Resources:
     Type: AWS::IAM::Policy
     Condition: NeedQuickSightDataSourceRoleAndODC
     Properties:
-      PolicyName: S3Access
+      PolicyName: QuickSightDataSource-S3AccessODC
       PolicyDocument:
         Version: 2012-10-17
         Statement:
@@ -1099,7 +1104,7 @@ Resources:
     Type: AWS::IAM::Policy
     Condition: NeedQuickSightDataSourceRoleAndCUR
     Properties:
-      PolicyName: S3Access
+      PolicyName: QuickSightDataSource-S3AccessCUR
       PolicyDocument:
         Version: 2012-10-17
         Statement:
Original file line number	Diff line number	Diff line change
Expand Up		@@ -57,3 +57,4 @@ venv.bak/

		#Local dev and testing files
		cfn-templates/parameters.local
		sandbox/