-
Notifications
You must be signed in to change notification settings - Fork 92
fix(kafka): Handle message indices in proto data also for Glue Schema Registry #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Outdated
Show resolved
Hide resolved
|
.../java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializerTest.java
Show resolved
Hide resolved
.../java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializerTest.java
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/AbstractKafkaDeserializer.java
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/KafkaProtobufDeserializer.java
Show resolved
Hide resolved
...main/java/software/amazon/lambda/powertools/kafka/serializers/AbstractKafkaDeserializer.java
Show resolved
Hide resolved
Hey @karthikpswamy. Thanks again for contributing this logic. To unblock work during my timezone I created a copy of your PR here: #1907. Please review it. I did some minor changes but the key change is that I updated the GLUE Schema ID size to 36 because this is length of the uuids. Can you let me know if this is correct? |
Issue #, if available:
Description of changes:
Schema Registry Type Detection and Deserialization Logic:
No Schema Registry Integration:
Identified by 16-byte schema ID in key/value metadata
Default case when neither of above conditions are met
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.