Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow and have workflow run on pull requests #393

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

humivo
Copy link
Contributor

@humivo humivo commented Apr 24, 2023

Description: Fix the workflow dependencies and have the integration test workflow run on pull requests to master.

Testing Performed: Local testing performed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bryan-aguilar
Copy link
Contributor

This workflow uses secrets. Secrets are not usable in fork origin pull requests. We either need to remove the dependency on the secret, open an issue similar to the collector indicating fork origin pull requests are blocked, or not run this on push. There also may be other ways to solve those other than those three options. If you have ideas lets explore them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants